Report current file size during writes #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mountpoint-s3/src/inode.rs
Outdated
| @@ -960,6 +960,11 @@ impl Inode { | |||
| *lookup_count | |||
| } | |||
|
|
|||
| pub fn inc_file_size(&self, len: usize) { | |||
| let mut state = self.inner.sync.write().unwrap(); | |||
| state.stat.update_size(len); | |||
There was a problem hiding this comment.
Don't think this needs to be a method if it only has one caller
Suggested change
| state.stat.update_size(len); | |
| state.stat.size += len; |
monthonk
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
monthonk
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
monthonk
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
monthonk
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Mountpoint currently reports file size as 0 until the upload is complete. In this commit, we instead report how many bytes have been streamed to S3 as some applications want to know current size of the file during writes. Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
approved these changes
Jul 18, 2023
passaro
added a commit
to passaro/mountpoint-s3
that referenced
this pull request
Nov 30, 2023
Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 dc90010..de36fee: > Bypass for CreateSession reqeust (awslabs#384) > Mem limiter validation (awslabs#385) > Fix tests to use net_test_case (awslabs#383) Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Update CRT submodules to latest releases (aws-c-s3 0.4.3) Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 dc90010..de36fee: > Bypass for CreateSession reqeust (#384) > Mem limiter validation (#385) > Fix tests to use net_test_case (#383) Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> * Update S3CrtClient test to reflect loosened part size constraint Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk> --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Mountpoint currently reports file size as 0 until the upload is complete. In this commit, we instead report how many bytes have been streamed to S3 as some applications want to know current size of the file during writes.
Does this change impact existing behavior?
Yes, uncommitted file size will be displayed as total streamed bytes instead of 0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).