Feature/adding-byokg-unit-testing#137
Merged
iansrobinson merged 3 commits intoawslabs:mainfrom Mar 9, 2026
Merged
Conversation
fbmz-improving
force-pushed
the
feature/adding-byokg-unit-testing
branch
from
eaed55d to
c694f9d
Compare
acarbonetto
approved these changes
Mar 5, 2026
acarbonetto
left a comment
acarbonetto
left a comment
There was a problem hiding this comment.
Looks good. Nice testing additions.
acarbonetto
reviewed
Mar 5, 2026
mykola-pereyma
suggested changes
Mar 5, 2026
fbmz-improving
force-pushed
the
feature/adding-byokg-unit-testing
branch
from
fbb8ed9 to
455deac
Compare
feat(byokg-rag): add comprehensive unit testing infrastructure with 94% coverage - Add pytest configuration and test infrastructure - Implement unit tests for all major components (graph connectors, retrievers, graphstore, indexing, LLM) - Add GitHub Actions workflow for automated testing - Update documentation with testing guidelines and coverage information updated design.md and removed .config.kiro
fbmz-improving
force-pushed
the
feature/adding-byokg-unit-testing
branch
from
b9fbcaf to
1fb27b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive unit test suite with 309 tests covering all core modules. Tests use mocked AWS services for fast, isolated execution.
Coverage: 94% overall (16 modules at 87-100%)
Note: Two FAISS tests deselected due to platform-specific segfaults
resolves #134
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.