Skip to content

Fix an issue in the install script where having no region set in the CLI errors unhelpfully. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brtrvn merged 2 commits into from
Sep 14, 2022
Merged

Fix an issue in the install script where having no region set in the CLI errors unhelpfully. #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f42339
Fix an issue where having no region set in the CLI errors unhelpfully.
Sep 13, 2022
7a0f6f7
Pipe grep output to /dev/null
Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ if ([string]::IsNullOrWhiteSpace($AWS_REGION))
echo "AWS_REGION not set, check your aws profile or set AWS_DEFAULT_REGION"
Exit 2
}
aws ec2 describe-regions | Select-String -Pattern "$AWS_REGION" | Out-Null
if (-not $?)
{
Write-host "Invalid region $AWS_REGION set, please set a valid region using aws configure"
Exit 2
}

cd ${CURRENT_DIR}
Write-host "Building requirements for SaaS Boost"
Expand Down
5 changes: 5 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ fi
# check for AWS region
if [ -z $AWS_DEFAULT_REGION ]; then
export AWS_REGION=$(aws configure list | grep region | awk '{print $2}')
aws ec2 describe-regions | grep "$AWS_REGION" - > /dev/null 2>&1
if [ $? -ne 0 ]; then
echo "Invalid region set, please set a valid region using \`aws configure\`"
exit 2
fi
if [ -z $AWS_REGION ]; then
echo "AWS_REGION environment variable not set, check your AWS profile or set AWS_DEFAULT_REGION."
exit 2
Expand Down