Fix an issue in the install script where having no region set in the CLI errors unhelpfully. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have no region set in the AWS CLI (doable by removing the 'region' line from `.aws/config`) the result of `aws configure list` will contain the string "<not set>" for the region, meaning the region is parsed incorrectly in the install script. This leads to an error when trying to run the installer that is potentially difficult for a new user to comprehend. This commit changes the parsing in the install scripts to also check the configured region against the list of regions using `aws ec2 describe-regions`. If the configured region does not exist in that list, the installer will prompt the user to configure a valid region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have no region set in the AWS CLI (doable by removing the 'region' line from
.aws/config) the result ofaws configure listwill contain the string "" for the region, meaning the region is parsed incorrectly in the install script. This leads to an error when trying to run the installer that is potentially difficult for a new user to comprehend.This commit changes the parsing in the install scripts to also check the configured region against the list of regions using
aws ec2 describe-regions. If the configured region does not exist in that list, the installer will prompt the user to configure a valid region.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license