Default ecsLaunchType to EC2 for Windows based services #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtrvn
commented
Aug 9, 2022
Contributor
Author
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Maybe a better UX here would be to show the launch type radio buttons for Windows, but pre-select EC2 and disable the control so it's clear what's going on. When we add Fargate support for Windows then we simply enable the launch type radio buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
ecsLaunchTypefor a service is not defined, set it toFARGATEwhen the container operating system is Linux andEC2when WindowsResolves #269
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license