Add UI support for selecting FSX Ontap for Windows Applications. #263
Conversation
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
The visibility of the radio buttons for FSx file system type looks to be controlled by the container OS radio button selection not the checkbox for whether you want to configure a file system or not.
Looks like we lost the FSx Windows defaults for throughput and storage and now show the FSx ONTAP defaults for both types.
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Looks like ecsLaunchType is left NULL when you select Windows for your Container OS. We can either show the Container Launch Type radio buttons for WIndows, set it to EC2 (for now) and disable it so the user can't change it, or we can set it on the backend to EC2 instead of NULL so onboarding doesn't fail.
|
Resolved the |
This commit also fixes a bug with the update_local_env.sh utility script. Co-authored-by: netapp-vedantsethia <Vedant.Sethia@netapp.com> Co-authored-by: netapp-dhruv-tyagi <Dhruv.Tyagi@netapp.com>
This commit allows for FSX ONTAP if Linux/EC2 are selected and fixes a small bug with the filesystem type selection where the radio buttons were showing if "Provision a FileSystem" was not selected. This commit also makes changes to the structuring of the FILESYSTEM_TYPES constants to allow for different form validation depending on whether the FSX_ONTAP OS is WINDOWS or LINUX.
brtrvn
left a comment
brtrvn
left a comment
There was a problem hiding this comment.
Looks good. Thank you for fixing the maintenance start time bug. And, I like that we're getting setup to support FSx ONTAP on Linux workloads launched on EC2!
2 participants
This commit also fixes a bug with the update_local_env.sh utility
script.
Co-authored-by: netapp-vedantsethia Vedant.Sethia@netapp.com
Co-authored-by: netapp-dhruv-tyagi Dhruv.Tyagi@netapp.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license