This repository was archived by the owner on May 21, 2025. It is now read-only.
Re-add handling of single value headers #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass context.Context from Lambda runtime to http.Request.
Api gw context to context
# Conflicts: # core/request.go # core/request_test.go
Revert handling of single value headers
kheppenstall
reviewed
Feb 4, 2020
core/response_test.go
Outdated
| @@ -154,7 +154,7 @@ var _ = Describe("ResponseWriter tests", func() { | |||
| Expect(err).To(BeNil()) | |||
|
|
|||
| // Headers are not written to `Headers` field | |||
There was a problem hiding this comment.
This comment makes it seem like this was intentional. If we want to use Headers and MultiValueHeaders then this comment does not make sense to keep.
nsarychev
changed the title
|
@sapessi Could you please review this when you get a chance? Thank you! |
|
As soon as the CI for the merge completes I'll tag |
|
Thank you for such a quick response @sapessi! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This commit d7b2b4e removed setting single-value headers, which caused all of our tests against gin break. This PR adds back the code to populate single-value headers as it did before. Please consider this for your review.
Note: There are commits in history from my previous merged PR #33. I was using same fork just updated it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.