This repository was archived by the owner on May 21, 2025. It is now read-only.
Add API GW Proxy context and Lambda Context to http.Request context #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass context.Context from Lambda runtime to http.Request.
|
For my own part (as a non-contributor/non-maintainer), this looks fine now, and provides a cleaner out-of-band way to bundle upstream context. |
extemporalgenome
approved these changes
Apr 28, 2019
|
@sapessi Will you take a look at this when you get a chance |
|
Thanks for te contribution @nsarychev and thanks @extemporalgenome for the review. I will take a look at this over the next couple of days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#27
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.