This repository was archived by the owner on May 21, 2025. It is now read-only.
Pass context.Context from Lambda runtime to http.Request. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be also fixed in core/request.go ProxyEventToHTTPRequest function. In that case the context would have to be added as an additional argument to that function which would break backward compatibility. Therefore I chose to implement the context pass-through in every Proxy function instead. |
|
Was there a problem with this change? Would love to see it reviewed. |
|
This was fixed in #33 by adding the new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Issue #, if available: 27
Description of changes: Pass context.Context from Lambda runtime to http.Request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.