Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Add adapter for the http.Handler interface #17

Merged
merged 4 commits into from
Dec 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions httpadapter/adapter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package httpadapter

import (
"net/http"

"github.com/aws/aws-lambda-go/events"
"github.com/awslabs/aws-lambda-go-api-proxy/core"
)

type HandlerAdapter struct {
core.RequestAccessor
handler http.Handler
}

func New(handler http.Handler) *HandlerAdapter {
return &HandlerAdapter{
handler: handler,
}
}

func (h *HandlerAdapter) Proxy(event events.APIGatewayProxyRequest) (events.APIGatewayProxyResponse, error) {
req, err := h.ProxyEventToHTTPRequest(event)
if err != nil {
return core.GatewayTimeout(), core.NewLoggedError("Could not convert proxy event to request: %v", err)
}

w := core.NewProxyResponseWriter()
h.handler.ServeHTTP(http.ResponseWriter(w), req)

resp, err := w.GetProxyResponse()
if err != nil {
return core.GatewayTimeout(), core.NewLoggedError("Error while generating proxy response: %v", err)
}

return resp, nil
}
45 changes: 45 additions & 0 deletions httpadapter/adapter_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package httpadapter_test

import (
"fmt"
"log"
"net/http"

"github.com/aws/aws-lambda-go/events"
"github.com/awslabs/aws-lambda-go-api-proxy/httpadapter"

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)

type handler struct{}

func (h handler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
w.Header().Add("unfortunately-required-header", "")
fmt.Fprintf(w, "Go Lambda!!")
}

var _ = Describe("HTTPAdapter tests", func() {
Context("Simple ping request", func() {
It("Proxies the event correctly", func() {
log.Println("Starting test")

var httpHandler http.Handler = http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
w.Header().Add("unfortunately-required-header", "")
fmt.Fprintf(w, "Go Lambda!!")
})

adapter := httpadapter.New(httpHandler)

req := events.APIGatewayProxyRequest{
Path: "/ping",
HTTPMethod: "GET",
}

resp, err := adapter.Proxy(req)

Expect(err).To(BeNil())
Expect(resp.StatusCode).To(Equal(200))
})
})
})
13 changes: 13 additions & 0 deletions httpadapter/handlerfunc_suite_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package httpadapter_test

import (
"testing"

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)

func TestHTTPAdapter(t *testing.T) {
RegisterFailHandler(Fail)
RunSpecs(t, "HttpAdapter Suite")
}