This repository was archived by the owner on May 21, 2025. It is now read-only.
Add adapter for the http.Handler interface
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2018 16:09
The adapter already uses handlerFunc via it's interface, calls `handlerFunc.ServeHTTP(args)` instead of `handlerFunc(args)`. Change to accept any interface implementation instead of only the `http.HandlerFunc` implementation.
Closed
pirfalt
changed the title
http.Handler implementation in HandlerFuncAdapterhttp.Handler interface
|
This seems like a no brainer to me. I don't really understand why there's a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #18
Description of changes:
Add a new
HandlerAdapterfor thehttp.HandlerFuncinterface.This is a general interface which all the other concrete adapter sources already implements. In addition to, example https://github.com/grpc-ecosystem/grpc-gateway and the go standard library.
Any of them could delegate to this adapter if they wanted to.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.