Fix bug where last few bytes on socket go unread #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` aws-c-auth v0.7.17 -> v0.7.22 aws-c-cal v0.6.11 -> v0.6.15 aws-c-common v0.9.15 -> v0.9.20 aws-c-http v0.8.1 -> v0.8.2 aws-c-io v0.14.7 -> v0.14.9 aws-c-mqtt v0.10.3 -> v0.10.4 aws-c-s3 v0.5.7 -> v0.5.10 aws-c-sdkutils v0.1.15 -> v0.1.16 aws-lc v1.24.0 -> v1.28.0 s2n v1.4.11 -> v1.4.15 ```
waahm7
approved these changes
Jun 4, 2024
something in v1.28.0 was breaking OpenBSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
awscrt.s3.S3Client is occasionally seeing errors when the server sends an HTTP response with a
Connection: closeheader (meaning it intends to close the connection after the response is sent). The server is sending the full response, then immediately hanging up. But the last few bytes of the response never make it to the HTTP client.Description of changes:
Update submodules, bringing in this fix: awslabs/aws-c-io#642
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.