Fix bug where last few bytes on socket go unread (#567)

graebm · web-flow · commit af29c1580726 · 2024-06-04T20:04:43.000-07:00
**Issue:** awscrt.s3.S3Client is occasionally seeing errors when the server sends an HTTP response with a `Connection: close` header (meaning it intends to close the connection after the response is sent). The server is sending the full response, then immediately hanging up. But the last few bytes of the response never make it to the HTTP client. **Description of changes:** Update submodules, bringing in this fix: awslabs/aws-c-io#642 ``` aws-c-auth v0.7.17 -> v0.7.22 aws-c-cal v0.6.11 -> v0.6.15 aws-c-common v0.9.15 -> v0.9.20 aws-c-http v0.8.1 -> v0.8.2 aws-c-io v0.14.7 -> v0.14.9 aws-c-mqtt v0.10.3 -> v0.10.4 aws-c-s3 v0.5.7 -> v0.5.10 aws-c-sdkutils v0.1.15 -> v0.1.16 s2n v1.4.11 -> v1.4.15 ```
diff --git a/crt/aws-c-auth b/crt/aws-c-auth
@@ -1 +1 @@
-Subproject commit 0de6b271bdfb447853d1af0eced39faed7f746f3
+Subproject commit 53a31bacf2918e848e00b052d2e25cba0be069d9
diff --git a/crt/aws-c-cal b/crt/aws-c-cal
@@ -1 +1 @@
-Subproject commit 314fc555846ac7bf2cc68a117c99a6af26f7043e
+Subproject commit 96c47e339d030d1fa4eaca201be948bc4442510d
diff --git a/crt/aws-c-common b/crt/aws-c-common
@@ -1 +1 @@
-Subproject commit ae7b067d9274d2d3faa1d3ae42d489a6986661f7
+Subproject commit 06cf4d82adad52723305dc2aeb06bb6439b5df7f
diff --git a/crt/aws-c-http b/crt/aws-c-http
@@ -1 +1 @@
-Subproject commit 98ec73ad0c18b78ba08d40b4e60d97abf794f24d
+Subproject commit d83f8d70143ddce5ab4e479175fbd44ba994211b
diff --git a/crt/aws-c-io b/crt/aws-c-io
@@ -1 +1 @@
-Subproject commit bf2d72230727f02eddb5b16c4e6c5ac5a3f203a7
+Subproject commit 878b4fa027bda4041493f06e0562d5e98bb3deb8
diff --git a/crt/aws-c-mqtt b/crt/aws-c-mqtt
@@ -1 +1 @@
-Subproject commit 74da9cadfa9dfd2179479fdc445617f5da3261ba
+Subproject commit ed7bbd68c03d7022c915a2924740ab7992ad2311
diff --git a/crt/aws-c-s3 b/crt/aws-c-s3
@@ -1 +1 @@
-Subproject commit 3334843eb4e0e56c2565e481b2ef853d1cadde78
+Subproject commit 6588f9a714ee7a8be1bddd63ea5ea1ea224d00b4
diff --git a/crt/aws-c-sdkutils b/crt/aws-c-sdkutils
@@ -1 +1 @@
-Subproject commit 638fdd6548df85c599f82db7ea70fd9e44917ef5
+Subproject commit 8c7af71f91ed5b9d2a043d51f120495f43723f80
diff --git a/crt/s2n b/crt/s2n
@@ -1 +1 @@
-Subproject commit 171c96a232eb2bf45415340378b55b3bb6dd29cd
+Subproject commit 6d92b46d309a8f12fa08ad289020d9a41c925a66
diff --git a/test/test_http_client.py b/test/test_http_client.py
@@ -57,7 +57,7 @@ def _start_server(self, secure, http_1_0=False):
 
         self.server = HTTPServer((self.hostname, 0), TestRequestHandler)
         if secure:
-            context = ssl.SSLContext()
+            context = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
             context.load_cert_chain(certfile='test/resources/unittest.crt', keyfile="test/resources/unittest.key")
             self.server.socket = context.wrap_socket(self.server.socket, server_side=True)
         self.port = self.server.server_address[1]
