Skip to content

Fix a bunch of places we forget to aws_raise_error() #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix a bunch of places we forget to aws_raise_error() #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dafc45
Fix a bunch of places we forget to aws_raise_error()
graebm Feb 9, 2024
a77b996
BUILDER_VERSION: v0.9.55
graebm Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- 'main'

env:
BUILDER_VERSION: v0.9.48
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-s3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:


env:
BUILDER_VERSION: v0.9.29
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-s3
Expand Down
2 changes: 1 addition & 1 deletion source/s3_checksums.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ int aws_checksum_compute(
case AWS_SCA_CRC32C:
return aws_checksum_compute_fn(allocator, input, output, aws_crc32c_checksum_new, truncate_to);
default:
return AWS_OP_ERR;
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}
}

Expand Down
10 changes: 5 additions & 5 deletions tests/s3_data_plane_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6919,7 +6919,7 @@ static int s_test_s3_put_pause_resume_happy_path(struct aws_allocator *allocator
aws_input_stream_destroy(resume_upload_stream);
aws_s3_tester_clean_up(&tester);

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

AWS_TEST_CASE(test_s3_put_pause_resume_all_parts_done, s_test_s3_put_pause_resume_all_parts_done)
Expand Down Expand Up @@ -6998,7 +6998,7 @@ static int s_test_s3_put_pause_resume_all_parts_done(struct aws_allocator *alloc
aws_input_stream_destroy(resume_upload_stream);
aws_s3_tester_clean_up(&tester);

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

AWS_TEST_CASE(test_s3_put_pause_resume_invalid_resume_data, s_test_s3_put_pause_resume_invalid_resume_data)
Expand Down Expand Up @@ -7076,7 +7076,7 @@ static int s_test_s3_put_pause_resume_invalid_resume_data(struct aws_allocator *
aws_input_stream_destroy(resume_upload_stream);
aws_s3_tester_clean_up(&tester);

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

AWS_TEST_CASE(test_s3_put_pause_resume_invalid_resume_stream, s_test_s3_put_pause_resume_invalid_resume_stream)
Expand Down Expand Up @@ -7159,7 +7159,7 @@ static int s_test_s3_put_pause_resume_invalid_resume_stream(struct aws_allocator
aws_input_stream_release(resume_upload_stream);
aws_s3_tester_clean_up(&tester);

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

AWS_TEST_CASE(test_s3_put_pause_resume_invalid_content_length, s_test_s3_put_pause_resume_invalid_content_length)
Expand Down Expand Up @@ -7238,7 +7238,7 @@ static int s_test_s3_put_pause_resume_invalid_content_length(struct aws_allocato
aws_input_stream_release(resume_upload_stream);
aws_s3_tester_clean_up(&tester);

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

/* Most basic test of the upload_review_callback */
Expand Down