-
Notifications
You must be signed in to change notification settings - Fork 22
Configure Unsampled Span Pipeline for Genesis #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yiyuan-he
wants to merge
7
commits into
aws-observability:main
Choose a base branch
from
yiyuan-he:setup-unsampled-span-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73a82f6
configure unsampled span pipeline for genesis agent observability
yiyuan-he f374872
ignore no-self-use lint check for new test cases
yiyuan-he 1e22bdf
Merge branch 'main' into setup-unsampled-span-pipeline
yiyuan-he a6e42da
Merge branch 'main' into setup-unsampled-span-pipeline
yiyuan-he 36198a7
rename test case method since already taken by baggage session id cha…
yiyuan-he 87b2e19
Merge branch 'main' into setup-unsampled-span-pipeline
yiyuan-he 173849a
Merge branch 'main' into setup-unsampled-span-pipeline
yiyuan-he File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make general as to
_export_unsampled_spans
, and have this check only needed where this function is called. Pass in spen_exporter if it is custom?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this refactor will be a bit risky given tight timeline. The logic in
_export_unsampled_span_for_lambda
doesn't seem straighforward to combine together with_export_unsampled_span_for_agent_observability
.Agree it would be good to combine both into
_export_unsampled_spans
, but maybe later on when there is more bandwidth to carefully test.What do you think?