Configure Unsampled Span Pipeline for Genesis #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
reviewed
Jun 17, 2025
Comment on lines
+269
to
+270
| if not is_agent_observability_enabled(): | ||
| return |
There was a problem hiding this comment.
Should we make general as to _export_unsampled_spans, and have this check only needed where this function is called. Pass in spen_exporter if it is custom?
There was a problem hiding this comment.
I feel like this refactor will be a bit risky given tight timeline. The logic in _export_unsampled_span_for_lambda doesn't seem straighforward to combine together with _export_unsampled_span_for_agent_observability.
Agree it would be good to combine both into _export_unsampled_spans, but maybe later on when there is more bandwidth to carefully test.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Configures unsampled span pipeline when
AGENT_OBSERVABILITY_ENABLEDis enabled.We always send 100% spans to Genesis platform for agent observability because AI applications typically have low throughput traffic patterns and require comprehensive monitoring to catch subtle failure modes like hallucinations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.