Skip to content

Conversation

@ps78674
Copy link
Contributor

@ps78674 ps78674 commented Mar 20, 2025

Issue #, if available:
aws-controllers-k8s/community#2387

Description of changes:
Remove following Terminal Error codes:
user.DefaultUserAssociatedToUserGroup;
cache_parameter_group.InvalidCacheParameterGroupState.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and michaelhtm March 20, 2025 10:10
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 20, 2025

Hi @ps78674. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @ps78674 !

cc @rushmash91

@ack-prow ack-prow bot added the approved label Mar 20, 2025
@rushmash91
Copy link
Member

/test elasticache-kind-e2e

@ps78674
Copy link
Contributor Author

ps78674 commented Mar 21, 2025

/test elasticache-verify-attribution

@rushmash91 rushmash91 force-pushed the update_terminal_err_codes branch from 0f84b62 to f4106f2 Compare March 28, 2025 22:55
@ack-prow
Copy link

ack-prow bot commented Mar 28, 2025

@ps78674: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution f4106f2 link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ps78674, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 4184f46 into aws-controllers-k8s:main Mar 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants