Unable to delete some resources

[ps78674]

Describe the bug
There are two resources, that not deleting ReplicationGroup removal:

• User associated with UserGroup as a default user can't be deleted because of a Terminal Err DefaultUserAssociatedToUserGroup, related log entry: {\"message\":\"DefaultUserAssociatedToUserGroup: User is associated to user group(s) as a default user and can't be deleted.\",\"status\":\"True\",\"type\":\"ACK.Terminal\"};
• CacheParameterGroup can't be deleted because of a Terminal Err InvalidCacheParameterGroupState, related log entry: {\"message\":\"InvalidCacheParameterGroupState: One or more cache clusters are still members of this parameter group my-parameter-group, so the group cannot be deleted.\",\"status\":\"True\",\"type\":\"ACK.Terminal\"}

Steps to reproduce
Create ReplicationGroup with UserGroup with default user & CacheParameterGroup, try to delete all objects.

Expected outcome
All resources should be deleted.

[github-actions]

Hello @ps78674 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[rushmash91]

Hi @ps78674 , they are terminal error because

The Modify API returns 400 in the following conditions:
Attempting to modify a parameter group that is currently associated with an active cache cluster
Trying to delete a parameter group that is in use.

Can you elaborate on why they should not be terminal errors?

[ps78674]

Because in case of a terminal error the controller stops reconciling and cache parameter group object newer deleted in the k8s cluster.

[rushmash91]

I think you should only be encountering "InvalidCacheParameterGroupState: One or more cache clusters are still members of this parameter group my-parameter-group, so the group cannot be deleted. if there are cache slusters in the parameter group.

Would you mind sharing the manifests? I can try to replicate the issue :)

[ps78674]

With all respect, I don't get your question. Cache clusters deleting slowly. When we try to delete all the objects (including parameter group) simultaneously – we get this error & reconciling stops because it's terminal.
I can share the manifests in a couple of days, if there is a need.

[michaelhtm]

Ohh, What if we tried not setting the error to terminal only during deletion? so it can keep reconciling and it eventually deletes the resource. Not sure if removing the terminal error completely is the right approach here
cc: @rushmash91 @a-hilaly

[ps78674]

Is there any update on this?

[a-hilaly]

Yeah i think we need to remove InvalidCacheParameterGroupState from terminal errors list. looks like a straightfoward fix, any one can pick this one up? @rushmash91 @michaelhtm

[rushmash91]

Hi @ps78674 , closing this issue as the PR was merged.

Feel free to reopen if still encounter this issue 🙂