-
Notifications
You must be signed in to change notification settings - Fork 20
Fix/update table gsi #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update table gsi #87
Conversation
Hi @joaquinservetto. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hey @a-hilaly, is there anything else missing to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joaquinservetto !
TIL You can reuse the same attributes to create more GSIs..
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, joaquinservetto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joaquinservetto Can we also add end2end tests to make sure that the table is in Synced stated? |
Issue #, if available:
aws-controllers-k8s/community#1920
Description of changes:
Fix error faced when creating a gsi for an existing table using already defined attributes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.