Error while updating Dynamodb with GSI

[riddhi2910]

Describe the bug
We upgraded the dynamodb controller to 1.2.3. We did that because in our previous version, when we updated the existing table with the globalSecondaryIndex . The controller was not able to create the GSI.
We created GSI manually on the AWS, after that added the configs for GSI on the ACK dyanmodb object.
We see errors like this afterwards
We think, the controller is not able to update/patch the changes. Creating a new table with GSI works fine.
conditions:

• message: Table in 'UPDATING' state, cannot be modified or deleted
  status: "True"
  type: ACK.Recoverable
• lastTransitionTime: "2023-10-04T20:44:04Z"
  message: Unable to determine if desired resource state matches latest observed
  state
  reason: Table in 'UPDATING' state, cannot be modified or deleted
  Steps to reproduce

Expected outcome
A concise description of what you expected to happen.

Environment

• Kubernetes version
• Using EKS (yes/no), if so version? Yes
• AWS service targeted (S3, RDS, etc.) Dynamodb

[a-hilaly]

We believe this might be fixed with aws-controllers-k8s/dynamodb-controller#73

[riddhi2910]

@a-hilaly Thanks, When will you be able to roll this out ?

[riddhi2910]

@a-hilaly Can I get an update on this?

[Julian-Chu]

@riddhi2910
could you please provide your yaml?

[joaquinservetto]

I'll be working on this one, @a-hilaly could you please assign the issue to me?

[a-hilaly]

@joaquinservetto Assigned to you - thank you! If you can, please provide more information on the provided spec - so that we have a good understand what's the issue is really about.

[joaquinservetto]

Hi @a-hilaly, I'll share the specs that I used to reproduce the issue, this only happens in the update process so you need to apply these manifests in the following order to face the error.

spec:
  attributeDefinitions:
  - attributeName: externalId
    attributeType: S
  - attributeName: test-numbers
    attributeType: "N"
  billingMode: PAY_PER_REQUEST
  continuousBackups:
    pointInTimeRecoveryEnabled: false
  keySchema:
  - attributeName: externalId
    keyType: HASH
  - attributeName: test-numbers
    keyType: RANGE
  tableClass: STANDARD
  tableName: test-0008-dev


spec:
  attributeDefinitions:
  - attributeName: externalId
    attributeType: S
  - attributeName: test-numbers
    attributeType: "N"
  globalSecondaryIndexes:
    - indexName: test-gsi
      projection:
        projectionType: ALL
      keySchema:
      - attributeName: test-numbers
        keyType: HASH
      - attributeName: externalId
        keyType: RANGE
  billingMode: PAY_PER_REQUEST
  continuousBackups:
    pointInTimeRecoveryEnabled: false
  keySchema:
  - attributeName: externalId
    keyType: HASH
  - attributeName: test-numbers
    keyType: RANGE
  tableClass: STANDARD
  tableName: test-0008-dev

[joaquinservetto]

@a-hilaly there were two bugs related to this issue, one of them was resolved by @Julian-Chu in this PR. I raised another one for an error that only happened when creating a gsi using previously defined attributes.

[a-hilaly]

@joaquinservetto Thanks for your contribution! Can you send a release PR? basically run RELEASE_VERSION=v1.2.5 ./scripts/build-controller-release.sh dynamodb and send a PR of the generated artifact

[a-hilaly]

@joaquinservetto Maybe before making a release let's add some e2e tests to make sure that the controller is being able to make the updates properly