-
Notifications
You must be signed in to change notification settings - Fork 232
Provide an option to configure a resource to requeue infinitely (Issue #826) #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to configure a resource to requeue infinitely (Issue #826) #95
Conversation
|
Hi @mbaijal. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
24b77b8 to
1535f80
Compare
b561ffe to
cb1bbe6
Compare
|
/approve |
…requeue (Issue #826) (#23) This PR is one of two to implement [Issue #826](aws-controllers-k8s/community#826) [Link to the code-generator PR ](aws-controllers-k8s/code-generator#95) ### Testing I tested the change by enabling it for applicationAutoscaling (ScalableTarget) - [you can check the generated code on this branch just for reference. ](aws-controllers-k8s/applicationautoscaling-controller#21)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, mbaijal, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is one of two to implement Issue #826
Link to the runtime PR
Testing
I tested the change by enabling it for applicationAutoscaling (ScalableTarget) - you can check the generated code on this branch just for reference.
Unit Test Result
Added 2 unit tests for the cases where the requeue duration is specified in the config file and where it isnt. Locally tested the unit test fails for incorrect assertions. successful result as follows -