Skip to content

Conversation

@mbaijal
Copy link
Contributor

@mbaijal mbaijal commented Jun 18, 2021

This PR is one of two to implement Issue #826
Link to the runtime PR

Testing

I tested the change by enabling it for applicationAutoscaling (ScalableTarget) - you can check the generated code on this branch just for reference.

Unit Test Result

Added 2 unit tests for the cases where the requeue duration is specified in the config file and where it isnt. Locally tested the unit test fails for incorrect assertions. successful result as follows -

(base) 147ddacd269c:code-generator mbaijal$ make test
go test -tags codegen ./...
?   	github.com/aws-controllers-k8s/code-generator/cmd/ack-generate	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/cmd/ack-generate/command	[no test files]
ok  	github.com/aws-controllers-k8s/code-generator/pkg/generate	(cached)
ok  	github.com/aws-controllers-k8s/code-generator/pkg/generate/ack	(cached)
ok  	github.com/aws-controllers-k8s/code-generator/pkg/generate/code	(cached)
?   	github.com/aws-controllers-k8s/code-generator/pkg/generate/config	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/pkg/generate/crossplane	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/pkg/generate/olm	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/pkg/generate/templateset	[no test files]
ok  	github.com/aws-controllers-k8s/code-generator/pkg/model	(cached)
ok  	github.com/aws-controllers-k8s/code-generator/pkg/names	(cached)
?   	github.com/aws-controllers-k8s/code-generator/pkg/testutil	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/pkg/util	[no test files]
?   	github.com/aws-controllers-k8s/code-generator/pkg/version	[no test files]

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 18, 2021

Hi @mbaijal. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mbaijal mbaijal changed the title Provide an option to configure a resource to requeue infinitely (Issue #826) [testing] Provide an option to configure a resource to requeue infinitely (Issue #826) Jun 18, 2021
@mbaijal mbaijal force-pushed the infinite-requeue-2 branch 2 times, most recently from 24b77b8 to 1535f80 Compare June 23, 2021 08:05
@mbaijal mbaijal force-pushed the infinite-requeue-2 branch from b561ffe to cb1bbe6 Compare June 23, 2021 23:32
@mbaijal mbaijal changed the title [testing] Provide an option to configure a resource to requeue infinitely (Issue #826) Provide an option to configure a resource to requeue infinitely (Issue #826) Jun 24, 2021
@vijtrip2
Copy link
Contributor

/approve

ack-bot pushed a commit to aws-controllers-k8s/runtime that referenced this pull request Jun 24, 2021
…requeue (Issue #826) (#23)

This PR is one of two to implement [Issue #826](aws-controllers-k8s/community#826) 
[Link to the code-generator PR ](aws-controllers-k8s/code-generator#95)

### Testing
I tested the change by enabling it for applicationAutoscaling (ScalableTarget) - [you can check the generated code on this branch just for reference. ](aws-controllers-k8s/applicationautoscaling-controller#21)
@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, mbaijal, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit 9c35918 into aws-controllers-k8s:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants