Address Review comments

Author: mbaijal

pkg/generate/config/resource.go

@@ -56,7 +56,7 @@ type ResourceConfig struct {
 	// very little consistency to the APIs that we can use to instruct the code
 	// generator :(
 	UpdateOperation *UpdateOperationConfig `json:"update_operation,omitempty"`
-	// ReconcileConfig describes options for controlling the reconciliation
+	// Reconcile describes options for controlling the reconciliation
 	// logic for a particular resource.
 	Reconcile *ReconcileConfig `json:"reconcile,omitempty"`
 	// UpdateConditionsCustomMethodName provides the name of the custom method on the

pkg/model/crd.go

@@ -478,12 +478,11 @@ func (r *CRD) ReconcileRequeuOnSuccessSeconds() int {
 		return 0
 	}
 	reconcile := resGenConfig.Reconcile
-	// handles the default case
-	if reconcile == nil {
-		return 0
-	} else {
+	if reconcile != nil {
 		return reconcile.RequeueOnSuccessSeconds
 	}
+	// handles the default case
+	return 0
 }
 
 // CustomUpdateMethodName returns the name of the custom resourceManager method

templates/pkg/resource/manager_factory.go.tpl

@@ -66,13 +66,13 @@ func (f *resourceManagerFactory) IsAdoptable() bool {
 	return {{ .CRD.IsAdoptable }}
 }
 
-// GetRequeueOnSuccessSeconds returns true if the resource should be requeued after specified seconds
+// RequeueOnSuccessSeconds returns true if the resource should be requeued after specified seconds
 // Default is false which means resource will not be requeued after success. 
-func (f *resourceManagerFactory) GetRequeueOnSuccessSeconds() (int, bool) {
+func (f *resourceManagerFactory) RequeueOnSuccessSeconds() int {
 {{- if $reconcileRequeuOnSuccessSeconds := .CRD.ReconcileRequeuOnSuccessSeconds }}
-	return {{ $reconcileRequeuOnSuccessSeconds }}, true
+	return {{ $reconcileRequeuOnSuccessSeconds }}
 {{- else }}
-	return 0, false
+	return 0
 {{- end }}
 }
 

templates/pkg/resource/sdk.go.tpl

@@ -246,13 +246,13 @@ func (rm *resourceManager) updateConditions (
 	if syncCondition == nil && onSuccess {
 		syncCondition = &ackv1alpha1.Condition{
 			Type:   ackv1alpha1.ConditionTypeResourceSynced,
+			Status: corev1.ConditionTrue,
 		}
-		syncCondition.Status = corev1.ConditionTrue
 		ko.Status.Conditions = append(ko.Status.Conditions, syncCondition)
 	}
 {{- else }}
 	// Required to avoid the "declared but not used" error in the default case
-	syncCondition = nil
+	_ = syncCondition
 {{- end }}
 
 {{- if $updateConditionsCustomMethodName := .CRD.UpdateConditionsCustomMethodName }}