Skip to content

Fix generated code not setting API payload for fields with type "union" #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

Fix generated code not setting API payload for fields with type "union" #628

merged 2 commits into from
Oct 9, 2025
+6,836 −4

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Oct 8, 2025

Issue #, if available: 2651

Description of changes:
This PR fixes the following issues with setSDKForUnion function.

  • Fixes union member values not being set in the API payload.
  • Fixes the the ACK controller's not setting an ACK.Terminal condition if more than one union member is set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knottnt added 2 commits October 8, 2025 10:12
@knottnt
Generate set of isInterfaceSet and input payload in setSDKForUnion
c5bf978 
- Add line for setting input payload field
- Add line for setting isInterfaceSet to true
- Fix indents in generated union set code
- Create test for emrcontainer's VirtualCluster union field.
@knottnt
Add test case for pipes-controller set_sdk generation
c66883c 
- Add test data for Pipes AWS Service
- Add test case for generating pipes CreateAPI
@ack-prow
Copy link

ack-prow bot commented Oct 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 October 8, 2025 18:48
@knottnt
Copy link
Contributor Author

knottnt commented Oct 8, 2025

/test all

@ack-prow ack-prow bot added the approved label Oct 8, 2025
@knottnt knottnt changed the title Fix union type set sdk Fix generated code not setting API payload for fields with type "union" Oct 8, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Oct 9, 2025

/test s3-controller-test

@knottnt knottnt marked this pull request as ready for review October 9, 2025 17:22
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Oct 9, 2025

Example of fix applied to emrcontainer-controller can be seen here

a-hilaly
a-hilaly approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt
Copy link
Contributor Author

knottnt commented Oct 9, 2025

/retest

@michaelhtm michaelhtm mentioned this pull request Oct 9, 2025
Merged
@knottnt
Copy link
Contributor Author

knottnt commented Oct 9, 2025

/retest

@michaelhtm
Copy link
Member

/test s3-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Oct 9, 2025

/retest

@ack-prow
Copy link

ack-prow bot commented Oct 9, 2025 •
edited
Loading

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution c66883c link false /test verify-attribution
s3-olm-test c66883c link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit eaabefb into aws-controllers-k8s:main Oct 9, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@michaelhtm michaelhtm michaelhtm approved these changes

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knottnt @michaelhtm @a-hilaly