Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Oct 8, 2025

Issue #, if available: 2651

Description of changes:

  • Fix VirtualCluster.ContainerProvider.EKSInfo not being populated in Create API Payload
  • Add .gitignore file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm October 8, 2025 19:53
@ack-prow ack-prow bot added the approved label Oct 8, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Oct 8, 2025

/test all

@knottnt knottnt marked this pull request as ready for review October 9, 2025 17:20
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@ack-prow ack-prow bot requested a review from rushmash91 October 9, 2025 17:20
@knottnt knottnt marked this pull request as draft October 9, 2025 17:21
@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@knottnt knottnt force-pushed the code-gen-union-fix branch from 5d88b89 to fc32eee Compare October 9, 2025 23:49
@knottnt knottnt marked this pull request as ready for review October 9, 2025 23:49
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 9, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
emrcontainers-verify-attribution fc32eee link false /test emrcontainers-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt knottnt changed the title Apply code-gen fix for union fields Fix VirtualCluster.ContainerProvider.EKSInfo not being populated in Create API Payload Oct 9, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 27f50a3 into aws-controllers-k8s:main Oct 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants