Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Next.js link & remove from UI drop-down #2411

Merged
merged 7 commits into from
Oct 22, 2020
Merged

Fix Next.js link & remove from UI drop-down #2411

merged 7 commits into from
Oct 22, 2020

Conversation

ericclemmons
Copy link
Contributor

Issue #, if available: Fixes #2408

Description of changes:

  • Fixes "jump to next step" link
  • Fixes drop-downs so Next.js shows up as an integration, but not in UI components or Library.

Screen Shot 2020-09-17 at 12 30 07 PM
Screen Shot 2020-09-17 at 12 30 14 PM
Screen Shot 2020-09-17 at 12 30 21 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericclemmons
Copy link
Contributor Author

ericclemmons commented Sep 17, 2020

@harrysolovay @jordanranz I had to revert 28dcb73 because Next.js stopped showing on the https://docs.amplify.aws/start page.

How you recommend I accomplish the following:

@sammartinez sammartinez removed the request for review from jordanranz September 24, 2020 17:18
@mauerbac
Copy link
Member

@sammartinez @harrysolovay - any update on this?

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@mauerbac
Copy link
Member

@harrysolovay , can you take a look at this when you have a chance ?

@sammartinez sammartinez deleted the 2408-next branch October 29, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback] Amplify Next.js getting started
4 participants