Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render required attributes by default in Vue #669

Merged
merged 7 commits into from
Nov 11, 2021
Merged

Render required attributes by default in Vue #669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f046e2b
Remove @todo-vue placeholders
ericclemmons Nov 10, 2021
cac4c00
Made updates to authenticator
Nov 10, 2021
3484b78
Merged main in
Nov 10, 2021
37bcc40
Cleaned up code
Nov 10, 2021
353297f
Updated debug message
Nov 10, 2021
2cd42e3
Fixed issue with custom sign up fields
Nov 11, 2021
8392e94
Fixed typo
Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove @todo-vue placeholders
  • Loading branch information
@ericclemmons
ericclemmons committed Nov 10, 2021
commit f046e2b2281a0c1c1bbbf255699e8cc8ca06058c
36 changes: 18 additions & 18 deletions packages/e2e/features/ui/components/authenticator/sign-up-with-attributes.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,77 +7,77 @@ Feature: Sign Up with Attributes
Background:
Given I'm running the example "ui/components/authenticator/sign-up-with-attributes"

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: Login mechanism set to "username"
Then I see "Username" as a "text" field
And I see "Email" as an "email" field
And I see "Phone Number" as a "tel" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Address
Then I don't see "Address"

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Birthdate
Then I see "Birthdate" as a "date" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Email
Then I see "Email" as an "email" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Family Name
Then I see "Family Name" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Middle Name
Then I see "Middle Name" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Gender
Then I don't see "Gender"

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Locale
Then I don't see "Locale"

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Given Name
Then I see "Given Name" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Name
Then I see "Name" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Nickname
Then I see "Nickname" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Phone Number
Then I see "Phone Number" as a "tel" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Preferred Username
Then I see "Preferred Username" as a "text" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Picture
Then I don't see "Picture"

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Profile
Then I see "Profile" as a "url" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Updated At
Then I don't see "Updated At"

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen has Website
Then I see "Website" as a "url" field

@todo-angular @react @todo-vue
@todo-angular @react @vue
Scenario: Sign Up screen does not have Zone Info
Then I don't see "Zone Info"

4 changes: 2 additions & 2 deletions packages/e2e/features/ui/components/authenticator/sign-up-with-phone.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ Feature: Sign Up with Phone
Then I see "Phone Number" as an input field
And I don't see "Username" as an input field

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: "Email" is included from `aws_cognito_verification_mechanisms`
Then I see "Email" as an "email" field

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: Sign up with valid phone number & password
When I select my country code with status "UNCONFIRMED"
And I type my "phone number" with status "UNCONFIRMED"
Expand Down
8 changes: 4 additions & 4 deletions packages/e2e/features/ui/components/authenticator/sign-up-with-username.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@ Feature: Sign Up with Username
Scenario: Login mechanism set to "username"
Then I see "Username" as an input field

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: "Preferred Username" is included from `aws_cognito_signup_attributes`
Then I see "Preferred Username" as a "text" field

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: "Email" is included from `aws_cognito_verification_mechanisms`
Then I see "Email" as an "email" field

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: "Phone Number" is not included
Then I don't see "Phone Number"

@angular @react @vue @todo-angular @todo-vue
@angular @react @vue @todo-angular
Scenario: Sign up a new username & password
Given I intercept '{ "headers": { "X-Amz-Target": "AWSCognitoIdentityProviderService.SignUp" } }' with fixture "sign-up-with-username"
When I type a new "username"
Expand Down