Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render required attributes by default in Vue #669

Merged
merged 7 commits into from
Nov 11, 2021
Merged

Render required attributes by default in Vue #669

merged 7 commits into from
Nov 11, 2021

Conversation

ericclemmons
Copy link
Contributor

Issue #, if available: #623, extending #650

Description of changes:

  • Remove @todo-vue placeholders

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericclemmons ericclemmons added the Vue An issue or a feature-request for Vue platform label Nov 10, 2021
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8392e94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericclemmons ericclemmons changed the title Render required attributes by default in Angular Render required attributes by default in Vue Nov 10, 2021
@ericclemmons ericclemmons temporarily deployed to ci November 10, 2021 18:50 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 10, 2021 18:50 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request introduces 10 alerts and fixes 9 when merging 3484b78 into 47e4296 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

fixed alerts:

  • 9 for Unused variable, import, function or class

@ErikCH ErikCH temporarily deployed to ci November 10, 2021 22:52 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request introduces 10 alerts and fixes 9 when merging 37bcc40 into 666122b - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

fixed alerts:

  • 9 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request introduces 10 alerts and fixes 9 when merging 353297f into 666122b - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

fixed alerts:

  • 9 for Unused variable, import, function or class

@ErikCH ErikCH temporarily deployed to ci November 10, 2021 23:42 Inactive
@ErikCH ErikCH marked this pull request as ready for review November 11, 2021 00:05
@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 10 alerts and fixes 9 when merging 2cd42e3 into 666122b - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

fixed alerts:

  • 9 for Unused variable, import, function or class

@ErikCH ErikCH temporarily deployed to ci November 11, 2021 00:15 Inactive
@ErikCH ErikCH temporarily deployed to ci November 11, 2021 00:15 Inactive
@ErikCH ErikCH temporarily deployed to ci November 11, 2021 00:15 Inactive
@ErikCH ErikCH requested a review from wlee221 November 11, 2021 00:36
wlee221
wlee221 reviewed Nov 11, 2021
View reviewed changes
packages/vue/src/components/alias-control.vue Outdated

const inferAutocomplete = computed((): string => {
return (
autocomplete || authInputAttributes[name as LoginMechanism]?.placeholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
autocomplete || authInputAttributes[name as LoginMechanism]?.placeholder
autocomplete || authInputAttributes[name as LoginMechanism]?.autocomplete

This is my bad! I see I made the same typo in Angular as well... 😓 I'll fix the Angular one soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Thanks, that's what I get for copying and pasting without checking. I'll fix it

wlee221
wlee221 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 10 alerts and fixes 9 when merging 8392e94 into f6d144d - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

fixed alerts:

  • 9 for Unused variable, import, function or class

@ErikCH ErikCH temporarily deployed to ci November 11, 2021 16:50 Inactive
@ErikCH ErikCH temporarily deployed to ci November 11, 2021 16:50 Inactive
@ErikCH ErikCH temporarily deployed to ci November 11, 2021 16:50 Inactive
@ErikCH ErikCH merged commit 1dccce8 into main Nov 11, 2021
@ErikCH ErikCH deleted the 623-signup-attributes-vue branch November 11, 2021 17:13
thaddmt pushed a commit that referenced this pull request Apr 7, 2023
@ayush987goyal
Merge pull request #669 from aws-amplify/pr/repo-sync
d51fd12 
Sync amplify-ui to amplify-ui-staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikCH ErikCH ErikCH left review comments

@wlee221 wlee221 wlee221 approved these changes

Assignees

@ErikCH ErikCH

Labels
Vue An issue or a feature-request for Vue platform
Projects
None yet
Milestone
Authenticator General Availability
Development

Successfully merging this pull request may close these issues.
3 participants
@ericclemmons @ErikCH @wlee221