Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional valid parameters to linting rules #6

Merged
merged 4 commits into from
Feb 16, 2019
Merged

Add additional valid parameters to linting rules #6

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f894c73
update linting rules
gingeranyhow Jan 15, 2019
e55040a
remove incorrect tag and file cleanup
gingeranyhow Jan 15, 2019
1d262d5
move valid params to all lowercase
gingeranyhow Jan 16, 2019
daa5c9d
two additional tags
gingeranyhow Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
two additional tags
  • Loading branch information
@gingeranyhow
gingeranyhow committed Jan 22, 2019
commit daa5c9d4724afba92ad932a7dd140dd6faf7f227
12 changes: 7 additions & 5 deletions app/linter/ink-linter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var glob = require('glob'),
fs = require('fs'),
colors = require('colors/safe');

var defaultDir = '../Assets/Ink Files/';

// Run just against GDC rides
Expand All @@ -11,15 +11,15 @@ var sendOutputToStream = false;
var collectedOutput;
// OR, run against all Rides
// var filesToLint = defaultDir + '{,GDCDemo/}' + "Rides/{**,!(NotInUse)/}*.ink"

/* RUN LINTING TESTS */
/* Run the command `ava linter-test.js` within the test directory

/* TODO:
Implement:
/* TODO:
Implement:
1. react tag with an emote arg, and vice versa - invalid: >>react:happy >>emote:squint
2. discuss the new, skipped test with Andrew. Is it worth trying to handle ink tags with colons, or are we just
reimplementing the Inky tag-parser.
reimplementing the Inky tag-parser.
3. (Defer) Character tags with mis-spelled characters

/* REGEX PATTERNS */
Expand Down Expand Up @@ -126,6 +126,7 @@ let storyTags = {
cutCamera: [
'linapov',
'linapovclose',
'linaclose',
'linafront',
'linafrontclose',
'paxleft',
Expand Down Expand Up @@ -163,6 +164,7 @@ let tagsWithoutEvents = {
["id",
"stars",
"Title",
'Subheader',
'cost',
"DisplayName",
"Reviewers",
Expand Down