Add additional valid parameters to linting rules #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awmcclain - LMK if you want any changes here! |
|
Also - I'm assuming you can squash merge, but if not I can make this a single clean commit. |
awmcclain
reviewed
Jan 15, 2019
app/linter/ink-linter.js
Outdated
| linaHands: ['checkwatch'] | ||
| cutCamera: [ | ||
| 'linapov', | ||
| 'LinaFrontClose', |
There was a problem hiding this comment.
Should these be all lower for the linter?
|
yea, they should. I had originally made a change that mapped through the
parameters and also put them lower-case, but decided to pull it out and
didn't update these. I'll test and put a new commit up in the morning.
…On Mon, Jan 14, 2019 at 8:59 PM Andrew McClain ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you thank you!!!!
------------------------------
In app/linter/ink-linter.js
<#6 (comment)>:
> @@ -57,8 +124,28 @@ let storyTags = {
linter: hasStoryTagError,
needsParam: true,
validParams: {
- cutCamera: ['linapov', 'paxleft', 'paxright', 'dashcam', 'hoodcam', 'linafront', 'city'],
- linaHands: ['checkwatch']
+ cutCamera: [
+ 'linapov',
+ 'LinaFrontClose',
Should these be all lower for the linter?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqWg7DTjbGZ2VL4lfX0TPM7HQaKZp6Nks5vDWA6gaJpZM4aAM_p>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.