Experimental dark mode #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jenspav
commented
Sep 11, 2024
jenspav
commented
Sep 11, 2024
README.md
Outdated
| | `generatr.site.externalTag` | Software systems containing this tag will be considered external | | | | ||
| | `generatr.site.nestGroups` | Will show software systems in the left side navigator in collapsable groups | `false` | `true` | | ||
| | `generatr.site.cdn` | Specifies the CDN base location for fetching NPM packages for browser runtime dependencies. Defaults to jsDelivr, but can be changed to e.g. an on-premise location. | `https://cdn.jsdelivr.net/npm` | `https://cdn.my-company/npm` | | ||
| | `generatr.site.darkMode` | Experimental: will show a dark mode menu item to switch between light and dark mode on the website. If turned off, the site will be shown in light mode and this menu item will not be shown. | `false` | `true` | |
There was a problem hiding this comment.
We could make this a three-state option: forced light theme, forced dark theme, auto (based on browser or user choice)
There was a problem hiding this comment.
Also add notes that colors for site and diagrams should be adjusted to any of those choices.
jenspav
force-pushed
the
dark-mode
branch
3 times, most recently
from
6051417
to
9ce8587
Compare
|
Ready to play. Note that the gray background in the light theme is gone. I think this fits, but taste may differ. |
Co-authored-by: LunarN0va <rubie157789@gmail.com>
Co-authored-by: LunarN0va <rubie157789@gmail.com>
Also move static styling to styles.css.
Plays slightly better with the dark theme,
dirkgroot
reviewed
Oct 1, 2024
Works better for the dark theme.
As discussed, lets go for bolder tab header for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switches to
structurizras the default exporter.Supersedes #528