Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #528

Closed
wants to merge 2 commits into from
Closed

Conversation

LunarN0va
Copy link
Contributor

@LunarN0va LunarN0va commented May 29, 2024

This PR features:

  • Applying the preferred color scheme of the user when first visiting the website.
  • A dark mode button at the right side of the navbar. This button uses icons from font-awesome.
  • Adding an option to disable dark mode. If disabled, the website will only be run in light mode and the dark mode button will not be shown.
  • A new library: font-awesome.
  • Added unittests voor HeaderBarViewModelTest: these unittests check if the dark mode button shows and doesn't show.
  • Fix for CDNTest cdn locations: this test didn't get included when running all the tests, this is fixed now.

Dark mode applied

Screenshot 2024-06-12 at 16 24 42

Light mode applied

Screenshot 2024-06-12 at 16 24 55

Some issues:

  • I don't like how the sun icon looks. I'm thinking I just make it a moon.
  • PlantUML diagrams don't convert to dark mode. I've been researching what a possible fix for changing the background colours of containers/componens and I think I'm going to look into the source files of the Structurizr DSL to better understand why the background colours can't change.

@LunarN0va LunarN0va force-pushed the feature/dark-mode branch 2 times, most recently from 61c6979 to 2ccec6d Compare June 12, 2024 14:11
@LunarN0va LunarN0va changed the title Draft: Implement dark mode when preferred in settings Add dark mode Jun 13, 2024
@jp7677
Copy link
Contributor

jp7677 commented Jun 17, 2024

May be this PR is a good reason to switch from the c4 to the structirizr exporter since that one plays a bit better with background styling.

@jenspav jenspav mentioned this pull request Sep 11, 2024
@jenspav
Copy link
Collaborator

jenspav commented Sep 11, 2024

Superseded by #606

@jenspav jenspav closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants