Skip to content

sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2025
Merged

sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header #1788

merged 4 commits into from
Oct 8, 2025

Conversation

@ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Oct 8, 2025 •
edited
Loading

@ceyonur ceyonur force-pushed the ceyonur/sync-coreth-1234 branch from 9f3fe3e to 0dcbb1a Compare October 8, 2025 08:30
@ceyonur ceyonur marked this pull request as ready for review October 8, 2025 11:33
@ceyonur ceyonur requested a review from a team as a code owner October 8, 2025 11:33
ARR4N
ARR4N requested changes Oct 8, 2025
View reviewed changes
ceyonur and others added 2 commits October 8, 2025 17:38
@ceyonur @ARR4N
Update core/genesis.go
59ddd4f 
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
@ceyonur
reviews
2946380
@JonathanOppenheimer JonathanOppenheimer changed the title ACP-226: Add MinDelayExcess to header (#1234) sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header Oct 8, 2025
JonathanOppenheimer
JonathanOppenheimer approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should try to avoid making additional changes on the sync PR unless the changes are specific to subnet-evm. We should sync the changes Arran made to this PR back to the coreth PR. Otherwise LGTM.

@ceyonur ceyonur added this pull request to the merge queue Oct 8, 2025
Merged via the queue into master with commit 9af16ac Oct 8, 2025
13 checks passed
@ceyonur ceyonur deleted the ceyonur/sync-coreth-1234 branch October 8, 2025 16:43
@ceyonur ceyonur mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ARR4N ARR4N ARR4N approved these changes

@powerslider powerslider powerslider approved these changes

@JonathanOppenheimer JonathanOppenheimer JonathanOppenheimer approved these changes

Assignees

@ceyonur ceyonur

Labels

acp226 coreth sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ceyonur @ARR4N @powerslider @JonathanOppenheimer