-
Notifications
You must be signed in to change notification settings - Fork 159
ACP-226: Add MinDelayExcess to header #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ceyonur
merged 9 commits into
master
from
ceyonur/acp-226-add-minblockdelayexcess-to-header
Sep 19, 2025
Merged
ACP-226: Add MinDelayExcess to header #1234
ceyonur
merged 9 commits into
master
from
ceyonur/acp-226-add-minblockdelayexcess-to-header
Sep 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e29be64 to
fa95632
Compare
ceyonur
commented
Sep 18, 2025
|
Shouldn't the header be added in |
I did not add checks and build path here. This just defines the field and adds to only necessary places to make UT pass. Mainly because we can't properly verify and set it while this PR is still pending ava-labs/avalanchego#4289 |
…ithub.com:ava-labs/coreth into ceyonur/acp-226-add-minblockdelayexcess-to-header
StephenButtolph
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds the
MinBlockDelayExcessto header and relevant places.Note: this does not properly handle/enforce the verification + build path yet.
Closes: #1231
How this works
Adds the field to header, runs generate tools.
How this was tested
Added the field to existing tests
Need to be documented?
maybe as a part of bigger ACP-226
Need to update RELEASES.md?
updated