Skip to content

chore(all): minor changes post-libevm merge #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 15, 2025

Conversation

qdm12
Copy link
Collaborator

@qdm12 qdm12 commented Apr 3, 2025

Why this should be merged

Minor changes suggested from the review of #1501

How this works

How this was tested

Need to be documented?

Need to update RELEASES.md?

@qdm12 qdm12 force-pushed the qdm12/libevm/final-minor-changes branch from b7b8cd0 to fd61099 Compare April 3, 2025 09:57
@qdm12 qdm12 force-pushed the qdm12/libevm/final-minor-changes branch from fd61099 to ef4659d Compare April 3, 2025 10:02
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide to use libevm for the other params in a different PR, looks good. But seems easier to do here

@qdm12 qdm12 marked this pull request as ready for review April 11, 2025 10:55
@qdm12 qdm12 requested review from ceyonur, darioush and a team as code owners April 11, 2025 10:56
@qdm12 qdm12 marked this pull request as draft April 11, 2025 10:56
@qdm12 qdm12 changed the base branch from libevm to master May 15, 2025 13:02
@qdm12 qdm12 marked this pull request as ready for review May 15, 2025 13:06
@qdm12 qdm12 added this pull request to the merge queue May 15, 2025
@qdm12 qdm12 removed this pull request from the merge queue due to a manual request May 15, 2025
@qdm12 qdm12 changed the title chore(all): minor changes to the libevm branch chore(all): minor changes post-libevm merge May 15, 2025
@qdm12 qdm12 added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit b1d4d89 May 15, 2025
13 checks passed
@qdm12 qdm12 deleted the qdm12/libevm/final-minor-changes branch May 15, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants