-
Notifications
You must be signed in to change notification settings - Fork 262
fix(all): critical fixes to the libevm branch #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c294ec
to
6c36ad4
Compare
490753a
to
73326c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are critical then they need tests, specifically ones that:
- Confirm that the ETH upgrades have been applied; and
- Verify a ChainConfig with invalid FeeConfig.
Tests added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the caveat of the comments I've made. This will still need Cey's review as a code owner.
Why this should be merged
Critical fixes only from review on #1501
Minor changes can be applied in #1552
How this works
How this was tested
Need to be documented?
Need to update RELEASES.md?