Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to use Warp API to gather signatures #119

Open
cam-schultz opened this issue Dec 19, 2023 · 2 comments
Open

Add config option to use Warp API to gather signatures #119

cam-schultz opened this issue Dec 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
We directly make AppRequests to validators for their BLS signatures, and then aggregate the signatures internally. Both subnet-evm and coreth provide a Warp API to do this instead. We should add a configuration option to use these APIs.

Discussion and alternatives
The main advantage of directly making AppRequests from the relayer is that this should work for any VM out of the box, whereas in order to use the API, the VM must provide that API (which is not guaranteed to have a standard interface with respect to other VMS) and the relayer must integrate it. The API approach would require more VM-specific code within the relayer, but would greatly simplify the signature aggregation complexity by offloading it to the VMs. We should consider what long term approach we want to take; likely supporting both will not be necessary nor desirable.

@cam-schultz
Copy link
Collaborator Author

We will need to provide the Warp API node endpoint as part of the configuration.

@iansuvak
Copy link
Contributor

Should we close this? It looks like it was fixed with #345 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review 👀
Development

No branches or pull requests

2 participants