Warp API support #345
Warp API support #345
Conversation
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
| ) | ||
| // Enable the Warp API for all source blockchains | ||
| for _, subnet := range relayerConfig.SourceBlockchains { | ||
| subnet.WarpAPIEndpoint = subnet.RPCEndpoint |
There was a problem hiding this comment.
Is there any (easy) way to check that the API endpoint is actually used by this test? Not necessary right now, but if the configuration changed in the future this test may silently pass if it falls back to using the P2P requests.
There was a problem hiding this comment.
Hmm that's a good question that I don't immediately know the best answer to. We could add distinct metrics and monitor those from the test. Those metrics would be useful in a deployment as well. I'll look into this.
There was a problem hiding this comment.
Added those metrics in and now check them in the test.
| networkLogLevel := logging.Error | ||
| if logLevel <= logging.Debug { | ||
| networkLogLevel = logLevel | ||
| } | ||
| network, err := peers.NewNetwork( | ||
| networkLogLevel, | ||
| registerer, | ||
| prometheus.DefaultRegisterer, |
There was a problem hiding this comment.
While adding in the new get signature metrics, I noticed that we also collect a TON of unrelated network and app requests metrics. This disables these extra metrics from being collected.
Co-authored-by: Michael Kaplan <55204436+michaelkaplan13@users.noreply.github.com> Signed-off-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
Co-authored-by: Michael Kaplan <55204436+michaelkaplan13@users.noreply.github.com> Signed-off-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
Co-authored-by: Michael Kaplan <55204436+michaelkaplan13@users.noreply.github.com> Signed-off-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
Why this should be merged
Fixe #119. Exposes config options to fetch Warp message aggregate signatures via the Warp API rather than app request.
How this works
Adds
SourceBlockchain.WarpAPIEndpointconfig option. Internally,ApplicationRelayersare composed of[rpc.Client](https://github.com/ava-labs/subnet-evm/blob/master/rpc/client.go)rather than[warp.Client](https://github.com/ava-labs/subnet-evm/blob/master/warp/client.go). This is becausewarp.Clientdoes not presently support query params or http headers, and expects the URI to be in a specific form.How this was tested
Added Warp API e2e test.
How is this documented
Updated README