C-Chain compatibility #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
relayer/message_relayer.go
Outdated
| return nil, err | ||
| } | ||
| return warpMsg, err | ||
| } else { |
There was a problem hiding this comment.
don't think we need this else
There was a problem hiding this comment.
Good call. Removed.
| @@ -311,7 +411,7 @@ func (r *messageRelayer) createSignedMessage(requestID uint32) (*warp.Message, e | |||
| } | |||
|
|
|||
| // As soon as the signatures exceed the stake weight threshold we try to aggregate and send the transaction. | |||
| if utils.CheckStakeWeightExceedsThreshold(accumulatedSignatureWeight, totalValidatorWeight, utils.DefaultQuorumNumerator, utils.DefaultQuorumDenominator) { | |||
| if utils.CheckStakeWeightExceedsThreshold(accumulatedSignatureWeight, totalValidatorWeight, params.WarpDefaultQuorumNumerator, params.WarpQuorumDenominator) { | |||
There was a problem hiding this comment.
should we by default be using the coreth.params? What if subnet-evm has different values, and the message we're sending doesn't interact with the primary network
There was a problem hiding this comment.
Yeah, we should make that distinction. I added a comment to #8 to fetch the numerator config from the VM, rather than using a hardcoded value.
geoff-vball
previously approved these changes
Dec 20, 2023
minghinmatthewlam
previously approved these changes
Dec 21, 2023
cam-schultz
dismissed stale reviews from minghinmatthewlam and geoff-vball
via
d12a01d
geoff-vball
approved these changes
Dec 21, 2023
michaelkaplan13
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With Avalanchego v1.10.17, Warp is enabled by default on the C-Chain for local networks, opening a path to easily test Teleporter and AWM Relayer. This PR adds E2E test cases to test relaying between the C-Chain and a subnet, as well as modifications to the relayer signature aggregation logic.
Fixes #113
Fixes #117
How this works
Modifies the internal signature aggregation logic to use the Warp client included insubnet-evmandcoreth, rather than the custom AppRequest logic. There are further changes needed to get the AppRequest approach working with the C-Chain, meanwhile the Warp client works out-of-the-box (issue here: Support AppRequests for the C-Chain #117)How this was tested
Extended E2E tests.
How is this documented
N/A