Remove UptimeManager#IsConnected #4333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
commented
Sep 24, 2025
ceyonur
reviewed
Sep 25, 2025
ceyonur
approved these changes
Sep 26, 2025
StephenButtolph
approved these changes
Sep 26, 2025
joshua-kim
added a commit
that referenced
this pull request
Sep 30, 2025
commit 47550e9 Author: Austin Larson <78000745+alarso16@users.noreply.github.com> Date: Mon Sep 29 11:24:22 2025 -0400 Add generics to x/sync (#4275) commit 8b8ac94 Author: Stephen Buttolph <stephen@avalabs.org> Date: Mon Sep 29 11:08:40 2025 -0400 Use `acp226.DelayExcess` rather than `uint64` (#4358) commit 32806e0 Author: Geoff Stuart <geoff.vball@gmail.com> Date: Fri Sep 26 16:40:10 2025 -0400 Support all validator set diffs by height (#4342) Signed-off-by: Geoff Stuart <geoff.vball@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 57a308a Author: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org> Date: Fri Sep 26 13:42:10 2025 -0400 Set `activationTime` equal to `upgrade.InitiallyActiveTime` for `propservm` (#4351) Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit d57e124 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Fri Sep 26 13:29:20 2025 -0400 Remove UptimeManager#IsConnected (#4333) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> commit 0985c16 Author: Geoff Stuart <geoff.vball@gmail.com> Date: Fri Sep 26 11:19:34 2025 -0400 Implement GetProposedHeight API in Proposervm (#4222) Signed-off-by: Michael Kaplan <55204436+michaelkaplan13@users.noreply.github.com> Co-authored-by: ylg <yang.linguan@avalabs.org> Co-authored-by: Michael Kaplan <55204436+michaelkaplan13@users.noreply.github.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Michael Kaplan <michael@avalabs.org> commit dfdd6a7 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Fri Sep 26 10:07:08 2025 -0400 Update daily re-execution benchmark (#4340) commit d8aa95f Author: letreturn <letreturn@outlook.com> Date: Fri Sep 26 22:12:02 2025 +0800 Typo Fixes (#4353) Signed-off-by: letreturn <letreturn@outlook.com> commit dbbfa66 Author: rodrigo <77309055+RodrigoVillar@users.noreply.github.com> Date: Fri Sep 26 00:02:29 2025 -0400 fix(load): only modify non-reserved slots (#4283) commit d0bcd73 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Sep 25 16:46:19 2025 -0400 Replace `mockable.MaxTime` with `upgrade.UnscheduledActivationTime` (#4322) commit 23c5718 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Sep 25 15:20:33 2025 -0400 Refactor Warp Verification Tests (#4335) commit cc72910 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Sep 25 15:16:19 2025 -0400 Remove premature optimization in validator manager (#4346) commit 36baa05 Author: Austin Larson <78000745+alarso16@users.noreply.github.com> Date: Thu Sep 25 14:38:53 2025 -0400 Granite ACP-176 (#4336) commit d74d90c Author: rodrigo <77309055+RodrigoVillar@users.noreply.github.com> Date: Thu Sep 25 14:38:42 2025 -0400 refactor(metervm): remove mockable clock (#4338) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
added a commit
that referenced
this pull request
Sep 30, 2025
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
JonathanOppenheimer
added a commit
that referenced
this pull request
Oct 1, 2025
This reverts commit d57e124.
michaelkaplan13
added a commit
that referenced
this pull request
Oct 1, 2025
This reverts commit d57e124.
JonathanOppenheimer
pushed a commit
that referenced
this pull request
Oct 1, 2025
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Slim down interface. Having
IsConnectedon the interface makes some edge-cases look confusing where we check for if the inner uptime manager is in-sync with us, which I'm not sure is possible or not (ref)How this works
Removes
IsConnectedfromUptimeManagerHow this was tested
UT added
Need to be documented in RELEASES.md?
No