Skip to content

Remove IsConnected from uptime manager interface #4355

@joshua-kim

Description

@joshua-kim

Chatted a bit offline - I think we can remove IsConnected on this manager type because the EVM's uptime tracker could derive that information from its own internal paused + connected validator set. To support the existing apis on the EVM though which do care about connected status, we'd have to update IsConnected to IsPaused so we could get if a validator was connected by checking IsPaused && peers.Has(nodeID). I don't feel like this is a big enough improvement to push on it more so I'm just going to close this PR. I might re-open this when evm is in avalanchego.

ref: #4333

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done 🎉

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions