-
Notifications
You must be signed in to change notification settings - Fork 841
[tmpnet] Enable deployment to kube #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e01ba97 to
ee9fcab
Compare
85bc291 to
513a7c4
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
e808653 to
9919ff2
Compare
9919ff2 to
d81e971
Compare
049efef to
a713bbc
Compare
d81e971 to
3126b84
Compare
bcb258c to
6714c80
Compare
2ef53c5 to
85c300b
Compare
| "", | ||
| logging.NewWrappedCore( | ||
| logging.Verbo, | ||
| logging.Info, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowering the level here so that the kube runtime logging is suppressed by default (it's more useful for debugging when implementing than useful for diagnosing a test suite).
Elvis339
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: maru <maru.newby@avalabs.org>
maru-ava
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my own PR because my personal account was the original author
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?
TODO