Skip to content

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Oct 17, 2024

Why this should be merged

This PR addresses a minor issue in testing, which causes the error to be printed as

  	Error:      	failed to bootstrap network: %s
  	Messages:   	failed to start local node: failed to load process context for node "NodeID-7JJiSVewCGTryysCg1kNNzaH3jKjC8FvY" before timeout: context deadline exceeded

instead of

  	Error:      network bootstrapping failed
  	Messages:   network bootstrapping error: failed to load process context for node "NodeID-7JJiSVewCGTryysCg1kNNzaH3jKjC8FvY" before timeout: context deadline exceeded

How this works

The source for the issue was the passing of %s as the first argument to the FailNow method.
Since the method doesn't format the first argument, the output would include the %s.

How this was tested

Tested manually.

@tsachiherman tsachiherman self-assigned this Oct 17, 2024
@tsachiherman tsachiherman requested a review from marun as a code owner October 17, 2024 18:17
@marun marun enabled auto-merge October 17, 2024 18:29
@marun marun added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit b840816 Oct 17, 2024
23 checks passed
@marun marun deleted the tsachi/improper-failnow branch October 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants