fix improper use of FailNow in testing (#3479)

tsachiherman · web-flow · commit b8408163669f · 2024-10-17T18:32:22.000Z
diff --git a/tests/fixture/e2e/helpers.go b/tests/fixture/e2e/helpers.go
@@ -249,7 +249,7 @@ func StartNetwork(
 		if stopErr := network.Stop(tc.DefaultContext()); stopErr != nil {
 			tc.Outf("failed to stop network after bootstrap failure: %v", stopErr)
 		}
-		require.FailNow("failed to bootstrap network: %s", err)
+		require.FailNowf("network bootstrapping failed", "network bootstrapping error: %s", err)
 	}
 
 	tc.Outf("{{green}}Successfully started network{{/}}\n")

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ func StartNetwork(`
`249`	`249`	`if stopErr := network.Stop(tc.DefaultContext()); stopErr != nil {`
`250`	`250`	`tc.Outf("failed to stop network after bootstrap failure: %v", stopErr)`
`251`	`251`	`}`
`252`		`- require.FailNow("failed to bootstrap network: %s", err)`
	`252`	`+ require.FailNowf("network bootstrapping failed", "network bootstrapping error: %s", err)`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`tc.Outf("{{green}}Successfully started network{{/}}\n")`