Skip to content

Reduce log level of failing to send a peerList message #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Reduce log level of failing to send a peerList message #2134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion network/peer/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,11 @@ func (p *peer) handleVersion(msg *p2p.Version) {
}

if !p.Send(p.onClosingCtx, peerListMsg) {
p.Log.Error("failed to send peer list for handshake",
// Because throttling was marked to be bypassed with this message,
// sending should only fail if the peer has started closing.
p.Log.Debug("failed to send peer list for handshake",
zap.Stringer("nodeID", p.id),
zap.Error(p.onClosingCtx.Err()),
)
}
}
Expand Down