Skip to content

Reduce log level of failing to send a peerList message #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

ERROR logs are only intended to be used for unexpected errors. This error can happen if a peer terminates its connection during the handshake.

How this works

Documents the behavior + reduces the log level to DEBUG from ERROR

How this was tested

N/A

@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking labels Oct 4, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Oct 4, 2023
@StephenButtolph StephenButtolph self-assigned this Oct 4, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 4, 2023
Merged via the queue into dev with commit 9aa3d25 Oct 4, 2023
@StephenButtolph StephenButtolph deleted the lower-networking-log-level branch October 4, 2023 17:03
@StephenButtolph StephenButtolph added the antithesis Related to an issue reported by Antithesis label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antithesis Related to an issue reported by Antithesis monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants