e2e: Ensure interchain workflow coverage for X-Chain and C-Chain #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
4 times, most recently
from
f13f760 to
9460e58
Compare
1 task
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
3 times, most recently
from
83e2078 to
3eaef23
Compare
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
3 times, most recently
from
40316dc to
8e661ff
Compare
marun
commented
Aug 20, 2023
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
from
8e661ff to
f60ce01
Compare
1 task
marun
changed the title
hexfusion
approved these changes
Aug 20, 2023
danlaine
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
The tests themselves LGTM but I left some questions/nits.
Also, personally I prefer to use
var (
thing1 = ...
thing2 = ...
)as opposed to
thing1 := ...
thing2 := ...when there are more than 2 things being declared consecutively. Not a binding style thing but I just like it better. Up to you.
| // Sign transaction | ||
| cChainID, err := ethClient.ChainID(e2e.DefaultContext()) | ||
| require.NoError(err) | ||
| signer := types.NewEIP155Signer(cChainID) |
There was a problem hiding this comment.
Someone who knows the EVM better than I do should comment as to whether this is the signer we want to use
There was a problem hiding this comment.
FWIW I'm copying what we used in snow-machine: https://github.com/ava-labs/snow-machine/blob/cchain-send/c/c.go#L37
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
from
2faec8c to
bf18183
Compare
|
Rebaed |
Closed
16 tasks
abi87
approved these changes
Aug 23, 2023
marun
force-pushed
the
e2e-kurtosis-interchain-workflow
branch
from
5ee2c53 to
6dfadc6
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
|
Removed superflous cchain default amount and invalid reference. |
StephenButtolph
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fulfills one of the requirements for #1547 (migration of Kurtosis tests)
How this works
How this was tested
CI
TODO
Implementation of the P-Chain workflow will be tackled in a different PR due to the dependency on node addition added by #1573.