Update golang to 1.20.8

.github/workflows/auto-generated-checker.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - uses: bufbuild/buf-setup-action@v1.26.1
       - shell: bash
@@ -30,7 +30,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - shell: bash
         run: scripts/mock.gen.sh

.github/workflows/build-and-test.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: build_test
         shell: bash

.github/workflows/build-linux-binaries.yml

@@ -19,7 +19,7 @@ jobs:
 
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
 
       - run: go version
@@ -81,7 +81,7 @@ jobs:
 
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
 
       - run: go version

.github/workflows/build-macos-release.yml

@@ -26,7 +26,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 

.github/workflows/build-public-ami.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 

.github/workflows/build-ubuntu-amd64-release.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 
@@ -78,7 +78,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 

.github/workflows/build-ubuntu-arm64-release.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 
@@ -78,7 +78,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - run: go version
 

.github/workflows/build-win-release.yml

@@ -26,7 +26,7 @@ jobs:
 
       - uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
 
       - run: go version

.github/workflows/fuzz.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: Run fuzz tests
         shell: bash

.github/workflows/static-analysis.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: Run static analysis tests
         shell: bash

.github/workflows/test.e2e.persistent.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: Build the avalanchego binary
         shell: bash

.github/workflows/test.e2e.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: Build the avalanchego binary
         shell: bash

.github/workflows/test.upgrade.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: '~1.19.12'
+          go-version: '~1.20.8'
           check-latest: true
       - name: Build the avalanchego binary
         shell: bash

.golangci.yml

@@ -19,6 +19,7 @@ linters:
     - bodyclose
     - depguard
     - errcheck
+    - errorlint
     - exportloopref
     - forbidigo
     - goconst
@@ -44,7 +45,6 @@ linters:
     - unparam
     - unused
     - whitespace
-    # - errorlint (TODO: re-enable in go1.20 migration)
     # - goerr113
     # - gomnd
     # - lll
@@ -121,7 +121,7 @@ linters-settings:
       - name: useless-break
         disabled: false
   staticcheck:
-    go: "1.19"
+    go: "1.20"
     # https://staticcheck.io/docs/options#checks
     checks:
       - "all"

CONTRIBUTING.md

@@ -4,7 +4,7 @@
 
 To start developing on AvalancheGo, you'll need a few things installed.
 
-- Golang version >= 1.19.12
+- Golang version >= 1.20.8
 - gcc
 - g++
 

Dockerfile

@@ -4,7 +4,7 @@
 # README.md
 # go.mod
 # ============= Compilation Stage ================
-FROM golang:1.19.12-bullseye AS builder
+FROM golang:1.20.8-bullseye AS builder
 
 WORKDIR /build
 # Copy and download avalanche dependencies using go mod

README.md

@@ -22,7 +22,7 @@ The minimum recommended hardware specification for nodes connected to Mainnet is
 
 If you plan to build AvalancheGo from source, you will also need the following software:
 
-- [Go](https://golang.org/doc/install) version >= 1.19.12
+- [Go](https://golang.org/doc/install) version >= 1.20.8
 - [gcc](https://gcc.gnu.org/)
 - g++
 

config/config.go

@@ -950,7 +950,7 @@ func getAliases(v *viper.Viper, name string, contentKey string, fileKey string)
 
 	aliasMap := make(map[ids.ID][]string)
 	if err := json.Unmarshal(fileBytes, &aliasMap); err != nil {
-		return nil, fmt.Errorf("%w on %s: %s", errUnmarshalling, name, err)
+		return nil, fmt.Errorf("%w on %s: %w", errUnmarshalling, name, err)
 	}
 	return aliasMap, nil
 }
@@ -1146,7 +1146,7 @@ func getSubnetConfigsFromDir(v *viper.Viper, subnetIDs []ids.ID) (map[ids.ID]sub
 
 		config := getDefaultSubnetConfig(v)
 		if err := json.Unmarshal(file, &config); err != nil {
-			return nil, fmt.Errorf("%w: %s", errUnmarshalling, err)
+			return nil, fmt.Errorf("%w: %w", errUnmarshalling, err)
 		}
 
 		if err := config.Valid(); err != nil {

config/flags.go

@@ -175,7 +175,6 @@ func addNodeFlags(fs *pflag.FlagSet) {
 	fs.Duration(BenchlistMinFailingDurationKey, constants.DefaultBenchlistMinFailingDuration, "Minimum amount of time messages to a peer must be failing before the peer is benched")
 
 	// Router
-	// TODO: Remove this flag in the future
 	fs.Duration(ConsensusAcceptedFrontierGossipFrequencyKey, constants.DefaultAcceptedFrontierGossipFrequency, "Frequency of gossiping accepted frontiers")
 	fs.Uint(ConsensusAppConcurrencyKey, constants.DefaultConsensusAppConcurrency, "Maximum number of goroutines to use when handling App messages on a chain")
 	fs.Duration(ConsensusShutdownTimeoutKey, constants.DefaultConsensusShutdownTimeout, "Timeout before killing an unresponsive chain")

database/leveldb/db.go

@@ -201,7 +201,7 @@ func New(file string, configBytes []byte, log logging.Logger, namespace string,
 	}
 	if len(configBytes) > 0 {
 		if err := json.Unmarshal(configBytes, &parsedConfig); err != nil {
-			return nil, fmt.Errorf("%w: %s", ErrInvalidConfig, err)
+			return nil, fmt.Errorf("%w: %w", ErrInvalidConfig, err)
 		}
 	}
 
@@ -231,7 +231,7 @@ func New(file string, configBytes []byte, log logging.Logger, namespace string,
 		db, err = leveldb.RecoverFile(file, nil)
 	}
 	if err != nil {
-		return nil, fmt.Errorf("%w: %s", ErrCouldNotOpen, err)
+		return nil, fmt.Errorf("%w: %w", ErrCouldNotOpen, err)
 	}
 
 	wrappedDB := &Database{

genesis/config.go

@@ -235,7 +235,7 @@ func GetConfigContent(genesisContent string) (*Config, error) {
 func parseGenesisJSONBytesToConfig(bytes []byte) (*Config, error) {
 	var unparsedConfig UnparsedConfig
 	if err := json.Unmarshal(bytes, &unparsedConfig); err != nil {
-		return nil, fmt.Errorf("%w: %s", errInvalidGenesisJSON, err)
+		return nil, fmt.Errorf("%w: %w", errInvalidGenesisJSON, err)
 	}
 
 	config, err := unparsedConfig.Parse()

go.mod

@@ -5,7 +5,7 @@ module github.com/ava-labs/avalanchego
 // Dockerfile
 // README.md
 // go.mod (here, only major.minor can be specified)
-go 1.19
+go 1.20
 
 require (
 	github.com/DataDog/zstd v1.5.2

proto/Dockerfile.buf

@@ -6,7 +6,7 @@ RUN apt-get update && apt -y install bash curl unzip git
 WORKDIR /opt
 
 RUN \
-  curl -L https://golang.org/dl/go1.19.12.linux-amd64.tar.gz > golang.tar.gz && \
+  curl -L https://golang.org/dl/go1.20.8.linux-amd64.tar.gz > golang.tar.gz && \
   mkdir golang && \
   tar -zxvf golang.tar.gz -C golang/
 

scripts/build_avalanche.sh

@@ -27,7 +27,7 @@ done
 # Dockerfile
 # README.md
 # go.mod
-go_version_minimum="1.19.12"
+go_version_minimum="1.20.8"
 
 go_version() {
     go version | sed -nE -e 's/[^0-9.]+([0-9.]+).+/\1/p'

snow/engine/snowman/transitive.go

@@ -435,7 +435,7 @@ func (t *Transitive) HealthCheck(ctx context.Context) (interface{}, error) {
 	if vmErr == nil {
 		return intf, consensusErr
 	}
-	return intf, fmt.Errorf("vm: %w ; consensus: %v", vmErr, consensusErr)
+	return intf, fmt.Errorf("vm: %w ; consensus: %w", vmErr, consensusErr)
 }
 
 func (t *Transitive) GetVM() common.VM {

snow/networking/handler/health.go

@@ -37,8 +37,7 @@ func (h *handler) HealthCheck(ctx context.Context) (interface{}, error) {
 	if networkingErr == nil {
 		return intf, engineErr
 	}
-	// TODO: Update this to return both errors with %w once we upgrade to Go 1.20
-	return intf, fmt.Errorf("engine: %v; networking: %v", engineErr, networkingErr)
+	return intf, fmt.Errorf("engine: %w; networking: %w", engineErr, networkingErr)
 }
 
 func (h *handler) networkHealthCheck() (interface{}, error) {

tests/fixture/testnet/local/network.go

@@ -422,39 +422,17 @@ func (ln *LocalNetwork) GetURIs() []string {
 	return uris
 }
 
-type NodeStopError struct {
-	NodeID    ids.NodeID
-	StopError error
-}
-
-func (e *NodeStopError) Error() string {
-	return fmt.Sprintf("failed to stop node %s: %v", e.NodeID, e.StopError)
-}
-
-type NetworkStopError struct {
-	Errors []*NodeStopError
-}
-
-func (e *NetworkStopError) Error() string {
-	return fmt.Sprintf("failed to stop network: %v", e.Errors)
-}
-
 // Stop all nodes in the network.
 func (ln *LocalNetwork) Stop() error {
-	errs := []*NodeStopError{}
+	var errs []error
 	// Assume the nodes are loaded and the pids are current
 	for _, node := range ln.Nodes {
 		if err := node.Stop(); err != nil {
-			errs = append(errs, &NodeStopError{
-				NodeID:    node.NodeID,
-				StopError: err,
-			})
+			errs = append(errs, fmt.Errorf("failed to stop node %s: %w", node.NodeID, err))
 		}
 	}
 	if len(errs) > 0 {
-		// TODO(marun) When avalanchego updates to go 1.20, update to
-		// use the new capability to wrap multiple errors.
-		return &NetworkStopError{Errors: errs}
+		return fmt.Errorf("failed to stop network:\n%w", errors.Join(errs...))
 	}
 	return nil
 }

utils/cb58/cb58.go

@@ -41,7 +41,7 @@ func Encode(bytes []byte) (string, error) {
 func Decode(str string) ([]byte, error) {
 	decodedBytes, err := base58.Decode(str)
 	if err != nil {
-		return nil, fmt.Errorf("%w: %s", ErrBase58Decoding, err)
+		return nil, fmt.Errorf("%w: %w", ErrBase58Decoding, err)
 	}
 	if len(decodedBytes) < checksumLen {
 		return nil, ErrMissingChecksum

utils/metric/averager.go

@@ -44,10 +44,10 @@ func NewAveragerWithErrs(namespace, name, desc string, reg prometheus.Registerer
 	}
 
 	if err := reg.Register(a.count); err != nil {
-		errs.Add(fmt.Errorf("%w: %s", ErrFailedRegistering, err))
+		errs.Add(fmt.Errorf("%w: %w", ErrFailedRegistering, err))
 	}
 	if err := reg.Register(a.sum); err != nil {
-		errs.Add(fmt.Errorf("%w: %s", ErrFailedRegistering, err))
+		errs.Add(fmt.Errorf("%w: %w", ErrFailedRegistering, err))
 	}
 	return &a
 }

vms/components/avax/utxo_id.go

@@ -68,12 +68,12 @@ func UTXOIDFromString(s string) (*UTXOID, error) {
 
 	txID, err := ids.FromString(ss[0])
 	if err != nil {
-		return nil, fmt.Errorf("%w: %v", errFailedDecodingUTXOIDTxID, err)
+		return nil, fmt.Errorf("%w: %w", errFailedDecodingUTXOIDTxID, err)
 	}
 
 	idx, err := strconv.ParseUint(ss[1], 10, 32)
 	if err != nil {
-		return nil, fmt.Errorf("%w: %v", errFailedDecodingUTXOIDIndex, err)
+		return nil, fmt.Errorf("%w: %w", errFailedDecodingUTXOIDIndex, err)
 	}
 
 	return &UTXOID{