Update golang to 1.20.8 #1826
Merged
Update golang to 1.20.8 #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
gyuho and
hexfusion
as code owners
darioush
previously approved these changes
Aug 8, 2023
StephenButtolph
commented
Aug 8, 2023
danlaine
previously approved these changes
Aug 8, 2023
| fs.Duration(BenchlistMinFailingDurationKey, constants.DefaultBenchlistMinFailingDuration, "Minimum amount of time messages to a peer must be failing before the peer is benched") | ||
|
|
||
| // Router | ||
| // TODO: Remove this flag in the future |
There was a problem hiding this comment.
Why's this TODO removed? Do we no longer intend to remove this flag?
There was a problem hiding this comment.
The flag was already removed (but the todo wasn't)
StephenButtolph
added
the
DO NOT MERGE
StephenButtolph
removed
the
DO NOT MERGE
abi87
approved these changes
Sep 6, 2023
hexfusion
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #1823
How this works
Updates all references to go1.20 and resolves the TODOs around updating to go1.20.
How this was tested
CI