Add Primary Network Partial Sync Option #1769
Conversation
|
state-sync prefers nodes that provide bandwidth and bootstrapping prefers validators - so I don't think this should impact bootstrapping times - even if widely adopted. |
chains/manager.go
Outdated
| NodeID ids.NodeID // The ID of this node | ||
| NetworkID uint32 // ID of the network this node is connected to | ||
| Server server.Server // Handles HTTP API calls | ||
| LiteSyncPrimaryNetwork bool |
There was a problem hiding this comment.
nit: put next to NetworkID
There was a problem hiding this comment.
moved - lmk if that was where you were thinking
chains/manager.go
Outdated
| return "node is a primary network validator", errNoLiteSyncForValidators | ||
| }) | ||
|
|
||
| if err := m.Health.RegisterHealthCheck("validation", liteSyncCheck, health.ApplicationTag); err != nil { |
There was a problem hiding this comment.
nit: not sure validation is the right name for this?
There was a problem hiding this comment.
I feel like it makes sense... The check is verifying that the node is not validating
StephenButtolph
added
consensus
| m.Log.Warn("node is a primary network validator", | ||
| zap.Error(errPartialSyncAsAValidator), | ||
| ) | ||
| return "node is a primary network validator", errPartialSyncAsAValidator |
There was a problem hiding this comment.
I could see us removing this at some point for the reasons I shared previously.
There was a problem hiding this comment.
I think it's fine for now at least
| return "node is a primary network validator", errPartialSyncAsAValidator | ||
| }) | ||
|
|
||
| if err := m.Health.RegisterHealthCheck("validation", partialSyncCheck, health.ApplicationTag); err != nil { |
There was a problem hiding this comment.
nit: "validation" -> "partial_validation"
There was a problem hiding this comment.
hmmm I was thinking this was the "am I a primary network validator" check - not the "am I correctly configured to partially validate state"
StephenButtolph
changed the title
Why this should be merged
Non-validators nodes tracking a subnet should not be required to track all primary network chains. This PR introduces a reduced mode configuration, where C-chain and X-chain are not instantiated and only P-chain is (partially) validated.
How this works
The PR introduces a reduced-mode configuration. If active:
How this was tested