Skip to content

Only return accepted blocks in GetStatelessBlock #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jul 18, 2023
Merged

Only return accepted blocks in GetStatelessBlock #1724

merged 23 commits into from
Jul 18, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

We no longer persist rejected blocks to disk following #1696. GetStatelessBlock should no longer return any non-accepted blocks.

Note: Pruning existing rejected blocks on disk will be done in a subsequent PR.

How this works

Modify function signature and treat non-accepted blocks as database.ErrNotFound errors.

How this was tested

CI

@dhrubabasu dhrubabasu added the vm This involves virtual machines label Jul 17, 2023
@dhrubabasu dhrubabasu added this to the v1.10.5 milestone Jul 17, 2023
@dhrubabasu dhrubabasu requested a review from abi87 as a code owner July 17, 2023 21:51
@dhrubabasu dhrubabasu self-assigned this Jul 17, 2023
StephenButtolph
StephenButtolph reviewed Jul 17, 2023
View reviewed changes
@dhrubabasu dhrubabasu force-pushed the get-stateless-block-accepted-blocks-only branch from 1e5c581 to e2f5f39 Compare July 17, 2023 23:12
@dhrubabasu dhrubabasu changed the base branch from dev to simplify-new-sized-cache July 17, 2023 23:54
Base automatically changed from simplify-new-sized-cache to dev July 18, 2023 00:19
@StephenButtolph StephenButtolph changed the title only return accepted blocks in GetStatelessBlock Only return accepted blocks in GetStatelessBlock Jul 18, 2023
StephenButtolph
StephenButtolph approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for real this time

@StephenButtolph StephenButtolph merged commit cccba11 into dev Jul 18, 2023
@StephenButtolph StephenButtolph deleted the get-stateless-block-accepted-blocks-only branch July 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abi87 abi87 abi87 left review comments

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

@danlaine danlaine Awaiting requested review from danlaine

Assignees

@dhrubabasu dhrubabasu

Labels
vm This involves virtual machines
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@dhrubabasu @patrick-ogrady @abi87 @StephenButtolph